chore: replace pre-commit with prek in Makefile and remove debug print statement in queue.py#16
Conversation
…t statement in queue.py
Summary of ChangesHello @jason810496, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the development environment setup by migrating the pre-commit hook installation from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs two useful maintenance tasks: replacing pre-commit with prek in the Makefile and removing a debug print statement in pgmq_sqlalchemy/queue.py. These changes are correct and improve the project's hygiene.
However, during the review of pgmq_sqlalchemy/queue.py, I discovered critical SQL injection vulnerabilities in several methods that are not part of this PR's changes. Functions like send, send_batch, delete, delete_batch, archive, and archive_batch (and their internal _sync/_async counterparts) construct SQL queries using f-strings with user-provided inputs like queue_name. This is a severe security risk.
The _set_vt_async function, which was modified in this PR, correctly uses parameterized queries, making it safe from such vulnerabilities. I strongly recommend that all other database-interacting methods in this file be refactored to use parameterized queries, following the example of _set_vt_async. This should be addressed as a high-priority issue in a subsequent pull request.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
1 participant
No description provided.